feat: add support for loading rules from global and project-local .roo directories #5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa190a9 to
bd23c9d
Compare
daniel-lxs
reviewed
Jun 23, 2025
|
|
||
| const result = await loadRuleFiles(mockCwd) | ||
|
|
||
| originalConsoleLog("Result:", result) |
There was a problem hiding this comment.
The tests include originalConsoleLog calls that don't seem to be used in the implementation. Could these be removed or converted to test assertions for cleaner tests?
…lobal directory detection - Replace rooDir.includes(path.join(os.homedir(), '.roo')) with exact path comparison - Use path.resolve() for robust path matching instead of string inclusion - Import and use getGlobalRooDirectory() for consistency - Add comprehensive tests for edge cases including paths with '.roo' in home directory - Update existing test mocks to support new getGlobalRooDirectory function This fixes potential false positives when home directory paths contain '.roo' elsewhere, making the global vs project directory detection more reliable and maintainable.
…ted filesystem errors - Replace broad catch-all error handling with specific error code checking - Only catch expected errors (ENOENT, ENOTDIR, EISDIR) in filesystem operations - Allow unexpected errors (EACCES, EIO, etc.) to propagate for proper diagnosis - Update directoryExists(), fileExists(), and readFileIfExists() functions - Add comprehensive test coverage for both expected and unexpected error scenarios - Verify loadConfiguration() properly propagates errors from file operations This prevents masking of critical system errors like permission issues, I/O failures, and disk problems while maintaining graceful handling of expected "file not found" cases. Improves debugging capabilities and follows error handling best practices. Fixes potential issues where permission denied or I/O errors were silently treated as "file doesn't exist", making troubleshooting difficult in production environments.
…d examples and usage
bd23c9d to
edde83a
Compare
daniel-lxs
approved these changes
Jun 24, 2025
thanks you for polish it <3 |
mrubens
approved these changes
Jun 24, 2025
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
…o directories (#5016) Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
…o directories (RooCodeInc#5016) Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4978
Description
Summary
This PR introduces a new hierarchical configuration system that supports both global (
~/.roo/) and project-local (.roo/) directories for organizing rules and configuration files. This enhancement provides better organization and allows users to define global defaults while maintaining project-specific overrides.What's Changed
🆕 New Features
~/.roo/rules/directory that apply across all projects.roo/rules/take precedence over global rulesrules-{mode}/directories🏗️ Architecture Changes
New
roo-configservice: Centralized service for managing .roo directory operationsgetGlobalRooDirectory()- Platform-aware global .roo path resolutiongetRooDirectoriesForCwd()- Ordered list of directories to checkloadConfiguration()- Unified configuration loading with merge supportdirectoryExists,fileExists,readFileIfExists)Enhanced
custom-instructionsmodule: Updated to use the new roo-config serviceTest Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds support for hierarchical rule loading from global and project-local
.roodirectories, with tests and backward compatibility.~/.roo/rules/) and project-local (.roo/rules/) directories.rules-{mode}/directories..roorulesfiles if no.roo/rulesdirectories exist.roo-configservice with functions:getGlobalRooDirectory(),getProjectRooDirectoryForCwd(),directoryExists(),fileExists(),readFileIfExists(),getRooDirectoriesForCwd(),loadConfiguration().custom-instructions.tsto useroo-configservice for rule loading.loadRuleFiles()andaddCustomInstructions()incustom-instructions-global.spec.ts.roo-configfunctions inindex.spec.ts.This description was created by
for fa190a9. You can customize this summary. It will automatically update as commits are pushed.