add support for endroid/qr-code version 6 #140
Conversation
willpower232
left a comment
There was a problem hiding this comment.
Thanks for your help, can you also add 6 to .github/workflows/test-endroid.yml to ensure it gets tested?
|
Thank you for looking at this so quickly! ^6 has been added to the list of tested package versions |
|
I suggest dropping versions 3 and 4 from our code/test. No need to try and be compatible with php 5.6 era libraries. Not necessarily in this PR, but adding support for a new version should come with dropping support for the oldest one, too. Or you end up with too many codepaths, maintenance cost, attack surface, etc... |
|
Its no skin off my back, they do still install on PHP 8 though so we'd have to add a conflicts in composer.json to reject those versions right? Probably easier to pull off next year with PHP 9 😅 |
Feature added
Updated EndroidQrCodeProvider to work with version 6 of optional endroid/qr-code repository. (Breaking change in dependency: setter methods removed in favor of more modern practice of passing properties to QrCode constructor)
Testing
Confirmed that EndroidQRCodeTest passes with either version 5 or 6 of endroid/qr-code installed