Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix issue #114 (Support for EndroidQR v5) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willpower232 merged 5 commits into from
Nov 14, 2023
Merged

Fix issue #114 (Support for EndroidQR v5) #115

willpower232 merged 5 commits into from
Nov 14, 2023

Conversation

@Mattie112
Copy link
Contributor

@Mattie112 Mattie112 commented Nov 10, 2023

The new version is using PHP ENUMs, added a check to make it compatible with v5.

Should also still work for v4 (and older)!

Tested with endroid/qr-code v4.8.5 and v5.0.2 with both versions I can generate a QR code.

            $qr_provider = new EndroidQrCodeProvider();
            $tfa = new TwoFactorAuth("xx", qrcodeprovider: $qr_provider);
            $qr = $tfa->getQRCodeImageAsDataUri("uid", $secret);

@Mattie112 Mattie112 mentioned this pull request Nov 10, 2023
Closed
@willpower232 willpower232 merged commit ab93dd4 into RobThree:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mattie112 @willpower232
Morty Proxy This is a proxified and sanitized view of the page, visit original site.