Don't treat \0 in description as literal null #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks, I'm not entirely understanding this fix. I've never seen a podspec that has the single-quote in the multiline literal like this. Could you elaborate? |
|
I hadn't seen it before either. The linked documentation on heredocs says that interpolation and escape sequences can be disabled by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think in the Gem description you meant to write
\0as human-readable text instead of a literal null byte. Heredoc strings interpret escapes unless you put single quotes like this. You can see it happening in the JSON version here where it says\u0000instead: https://github.com/CocoaPods/Specs/blob/98a5cfac82ecccd406eeff0d549c8eccadf1b699/Specs/2/e/c/RxSwift/6.8.0/RxSwift.podspec.json#L5https://docs.ruby-lang.org/en/master/syntax/literals_rdoc.html#label-Here+Document+Literals