Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixed test issuing non-serialized messages to the subject. #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjchristensen merged 1 commit into from
Dec 16, 2014
Merged

Fixed test issuing non-serialized messages to the subject. #1973

benjchristensen merged 1 commit into from
Dec 16, 2014

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 15, 2014

Should resolve the test failure of #1972 .

When the main part of the test succeded, an onCompleted was sent out from the main thread which was not serialized in respect to the onNext(1) issued from the worker thread, therefore, two replay was attempted sometimes. At first the caughtUp was seen false, the replay was entered but the next instruction cleared the index causing the IllegalStateException.

benjchristensen added a commit that referenced this pull request Dec 16, 2014
@benjchristensen
Merge pull request #1973 from akarnokd/ReplaySubjectFix1215
0f2e883 
Fixed test issuing non-serialized messages to the subject.
@benjchristensen benjchristensen merged commit 0f2e883 into ReactiveX:1.x Dec 16, 2014
@zsxwing
Copy link
Member

zsxwing commented Dec 18, 2014

Failed in https://travis-ci.org/ReactiveX/RxJava/builds/44421756

rx.subjects.ReplaySubjectBoundedConcurrencyTest > testReplaySubjectEmissionSubscriptionRace FAILED
    java.lang.NullPointerException
        at rx.subjects.ReplaySubject$BoundedState.replayObserverFromIndex(ReplaySubject.java:628)
        at rx.subjects.ReplaySubject$BoundedState.replayObserver(ReplaySubject.java:619)
        at rx.subjects.ReplaySubject.caughtUp(ReplaySubject.java:430)
        at rx.subjects.ReplaySubject.onCompleted(ReplaySubject.java:410)
        at rx.subjects.ReplaySubjectBoundedConcurrencyTest.testReplaySubjectEmissionSubscriptionRace(ReplaySubjectBoundedConcurrencyTest.java:399)

@akarnokd akarnokd deleted the ReplaySubjectFix1215 branch December 18, 2014 07:50
@akarnokd
Copy link
Member Author

akarnokd commented Dec 18, 2014

Thanks! Forgot about the other test class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @zsxwing @benjchristensen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.