Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Beta & Experimental Annotations #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjchristensen merged 1 commit into from
Nov 29, 2014
Merged

Beta & Experimental Annotations #1905

benjchristensen merged 1 commit into from
Nov 29, 2014

Conversation

@benjchristensen
Copy link
Member

@benjchristensen benjchristensen commented Nov 29, 2014

See #1824

@benjchristensen benjchristensen mentioned this pull request Nov 29, 2014
Closed
@benjchristensen
Copy link
Member Author

benjchristensen commented Nov 29, 2014

I chose rx.annotations but am open to suggestions for a better package name. It could perhaps be rx.lifecycle. I don't want rx.util or rx.common. We worked hard to eliminate those catch-all packages.

@daschl
Copy link
Contributor

daschl commented Nov 29, 2014

+1 on annotations

@benjchristensen
Copy link
Member Author

benjchristensen commented Nov 29, 2014

Thanks for voting on this so it's not just me!

@benjchristensen benjchristensen mentioned this pull request Nov 29, 2014
Closed
@akarnokd
Copy link
Member

akarnokd commented Nov 29, 2014

rx.annotations is okay with me as well.

@benjchristensen
Copy link
Member Author

benjchristensen commented Nov 29, 2014

I'm merging this then so we can start using it on some of the other PRs.

Thanks @daschl and @akarnokd for the review.

benjchristensen added a commit that referenced this pull request Nov 29, 2014
@benjchristensen
Merge pull request #1905 from benjchristensen/lifecycle-annotations
eb8254e 
Beta & Experimental Annotations
@benjchristensen benjchristensen merged commit eb8254e into ReactiveX:1.x Nov 29, 2014
@benjchristensen benjchristensen deleted the lifecycle-annotations branch November 29, 2014 21:44
@benjchristensen benjchristensen mentioned this pull request Dec 2, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjchristensen @daschl @akarnokd
Morty Proxy This is a proxified and sanitized view of the page, visit original site.