Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[html] fix convertLazyLoading: set img src to valid single url #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

[html] fix convertLazyLoading: set img src to valid single url #4743

wants to merge 1 commit into from

Conversation

User123698745
Copy link
Contributor

$img->src in convertLazyLoading is currently being set to an array of all srcset values. That is an invalid value. src must be a single url.
This PR splits the existing parseSrcset into parseSrcset without return_largest_url and parseSrcsetLargestImageUrl to make the intention more clear.
convertLazyLoading now uses parseSrcsetLargestImageUrl.
convertLazyLoading is mainly used by CssSelectorBridge and CssSelectorFeedExpanderBridge

@User123698745
[html] fix convertLazyLoading: set img src to valid single url instea…
bac049d 
…d array

used in:
bridges/CssSelectorBridge.php
bridges/CssSelectorFeedExpanderBridge.php
@github-actions GitHub Actions
Copy link

Pull request artifacts

Bridge Context Status
CssSelector 1 untitled (current) ❌ Bridge returned error 404! (20360)
❌ Type: HttpException
❌ Message: https://example.com/blog/ resulted in 404 Not Found
CssSelector 1 untitled (pr) ❌ Bridge returned error 404! (20360)
❌ Type: HttpException
❌ Message: https://example.com/blog/ resulted in 404 Not Found
CssSelectorFeedExpander 1 untitled (current) ❌ Bridge returned error 404! (20360)
❌ Type: HttpException
❌ Message: https://example.com/feed.xml resulted in 404 Not Found
CssSelectorFeedExpander 1 untitled (pr) ❌ Bridge returned error 404! (20360)
❌ Type: HttpException
❌ Message: https://example.com/feed.xml resulted in 404 Not Found

last change: Monday 2025-09-29 17:36:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@User123698745
Morty Proxy This is a proxified and sanitized view of the page, visit original site.