Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@ElianHugh
Copy link
Collaborator

What problem did you solve?

Closes #1404.

This PR adds another regex to check for chunk progress in the form of x/y. This appears to have been a change made to the rmarkdown package, so the previous implementation is needed for backwards compatibility.

How can I check this pull request?

With the latest version of rmarkdown, use vscode-R's knit preview or smart knit commands.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElianHugh ElianHugh merged commit 5438d82 into REditorSupport:master Feb 27, 2024
@ElianHugh ElianHugh deleted the fix-knit-progress branch February 27, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress tracking not working, it's always 0%.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.