Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Basic unit test for workspace viewer #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ElianHugh merged 5 commits into from
Feb 17, 2023
Merged

Basic unit test for workspace viewer #1305

ElianHugh merged 5 commits into from
Feb 17, 2023

Conversation

@ElianHugh
Copy link
Collaborator

@ElianHugh ElianHugh commented Feb 17, 2023

  • Introduces (very basic) unit testing for the workspace viewer

Also proposes unit testing through mocking the vscode API via the sinon library. E.g., we can "set" vscode.window.activeTextEditor via the following function:

export function mockActiveTextEditor(document: vscode.TextDocument, sandbox: sinon.SinonSandbox) {
    return sandbox.stub(vscode.window, 'activeTextEditor').value({
        document
    });
}

@ElianHugh
Basic unit test for RMD knitting
c37334e 
- Introduces unit testing for the background knitting of documents
(Also, an example of how we can use mocking/stubbing)
@ElianHugh
Increase timeout + linter
76b73e4
@ElianHugh
Add simple workspace viewer test
e8a596b
@ElianHugh
linter
a6a9676
renkun-ken
renkun-ken approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!

@ElianHugh ElianHugh merged commit db11fa0 into REditorSupport:master Feb 17, 2023
@ElianHugh ElianHugh deleted the unit-testing branch February 17, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renkun-ken renkun-ken renkun-ken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ElianHugh @renkun-ken
Morty Proxy This is a proxified and sanitized view of the page, visit original site.