Remove leading comments from terminal submission (#1244)#1245
Merged
renkun-ken merged 6 commits intoREditorSupport:masterREditorSupport/vscode-R:masterfrom Feb 1, 2023
gowerc:masterCopy head branch name to clipboard
Merged
Remove leading comments from terminal submission (#1244)#1245renkun-ken merged 6 commits intoREditorSupport:masterREditorSupport/vscode-R:masterfrom gowerc:masterCopy head branch name to clipboard
renkun-ken merged 6 commits intoREditorSupport:masterREditorSupport/vscode-R:masterfrom
gowerc:masterCopy head branch name to clipboard
Conversation
Contributor
Author
|
I’m now wondering if this instead should be moved to within expandselction? This current implementation would also strip leading comments off of explicitly highlighted chunks of code, though maybe that’s not an issue, I’m not too sure? |
renkun-ken
reviewed
Nov 24, 2022
Contributor
Author
|
Just wanted to apologies for not getting around to finishing this off myself, we just had a baby daughter which is consuming all my spare time at the moment 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Code removes leading comments from code submitted to terminal (issue #1244)
(If you have)Screenshot
remove_comments_screencast.webm