Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Misc edits to need for speed and numpy lectures#339

Merged
mmcky merged 4 commits intomainQuantEcon/lecture-python-programming.myst:mainfrom
small_updatesQuantEcon/lecture-python-programming.myst:small_updatesCopy head branch name to clipboard
Mar 12, 2025
Merged

Misc edits to need for speed and numpy lectures#339
mmcky merged 4 commits intomainQuantEcon/lecture-python-programming.myst:mainfrom
small_updatesQuantEcon/lecture-python-programming.myst:small_updatesCopy head branch name to clipboard

Conversation

@jstac
Copy link
Contributor

@jstac jstac commented Mar 9, 2025

@mmcky , please check (or delegate) and merge when ready.

When I built the lectures, there was excess space around the figure matlab.png in need_for_speed.md.

@mmcky mmcky self-requested a review March 11, 2025 03:58
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac just one minor fix re: link destination

I think the migration of the vectorisation discussion to the numpy lecture is a great idea.

lectures/numpy.md Outdated Show resolved Hide resolved
@mmcky
Copy link
Contributor

mmcky commented Mar 11, 2025

  • @mmcky check spacing around image when CI building.

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

@github-actions github-actions bot temporarily deployed to pull request March 12, 2025 00:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 12, 2025 00:51 Inactive
@mmcky
Copy link
Contributor

mmcky commented Mar 12, 2025

thanks @jstac for these changes.

I have resized the matlab figure and it is fixed.

Screenshot 2025-03-12 at 11 53 40 am

@mmcky mmcky merged commit 12d7a0f into main Mar 12, 2025
5 checks passed
@mmcky mmcky deleted the small_updates branch March 12, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.