Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ci: Move flake8 to GitHub Actions with reviewdog. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2020
Merged

ci: Move flake8 to GitHub Actions with reviewdog. #2

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4469e
Improve docs on automated tests
timhoffm Apr 5, 2020
30d1396
Merge pull request #17040 from timhoffm/doc-test
QuLogic Apr 17, 2020
9dca177
ci: Move flake8 to GitHub Actions with reviewdog.
QuLogic Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions 39 doc/devel/coding_guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,24 +176,45 @@ Merging
A core dev should only champion one PR at a time and we should try to keep
the flow of championed PRs reasonable.

* Do not self merge, except for 'small' patches to un-break the CI or
when another reviewer explicitly allows it (ex, "Approve modulo CI
passing, may self merge when green").

.. _pr-automated-tests:

Automated tests
---------------

* Make sure the Travis, Appveyor, CircleCI, and codecov tests are passing
before merging.
Whenever a pull request is created or updated, various automated test tools
will run on all supported platforms and versions of Python.

* Make sure the Travis, Appveyor, CircleCI, and Azure pipelines are passing
before merging (All checks are listed at the bottom of the GitHub page of
your pull request). Here are some tips for finding the cause of the test
failure:

- If *Travis flake8* fails, you have a code style issue, which will be listed
near the bottom of the *Travis flake8* log.
- If any other Travis run fails, search the log for ``FAILURES``. The
subsequent section will contain information on the failed tests.
- If CircleCI fails, likely you have some reStructuredText style issue in
the docs. Search the CircleCI log for ``WARNING``.
- If Azure pipelines fail with an image comparison error, you can find the
images as *artifacts* of the Azure job:

- Whenever a pull request is created or updated, Travis and Appveyor
automatically runs the test suite on all versions of Python
supported by Matplotlib. The tox_ support in Matplotlib may be
useful for testing locally.
- Click *Details* on the check on the GitHub PR page.
- Click *View more details on Azure Pipelines* to go to Azure.
- On the overview page *artifacts* are listed in the section *Related*.


* Codecov and LGTM are currently for information only. Their failure is not
necessarily a blocker.

* tox_ is not used in the automated testing. It is supported for testing
locally.

.. _tox: https://tox.readthedocs.io/

* Do not self merge, except for 'small' patches to un-break the CI or
when another reviewer explicitly allows it (ex, "Approve modulo CI
passing, may self merge when green").

.. _pr-squashing:

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.