refactor: restructured into a package#763
Merged
refactor: restructured into a package#763
Conversation
KarlMae
approved these changes
Dec 17, 2024
Contributor
KarlMae
left a comment
There was a problem hiding this comment.
Seems to be working as expected, the build folder outputs seemed to match when building from master or from this branch.
We should do something about the cjs file eventually, though right now it was only moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package/javascript-apimock-socketto version9.2.1. For some reason Yarn resolved it to9.3.0. Tests fail with newer versions.Checklist