Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add check for input import before running FixInput#519

Merged
jmadler merged 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
Ionaru:fix_input_multiple_runsCopy head branch name to clipboard
Oct 24, 2019
Merged

Add check for input import before running FixInput#519
jmadler merged 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
Ionaru:fix_input_multiple_runsCopy head branch name to clipboard

Conversation

@Ionaru
Copy link
Contributor

@Ionaru Ionaru commented Oct 23, 2019

Check if from builtins import input is already present (result of raw_input fixer) and skip the input fixer if it does.

Fixes #427

@Ionaru
Copy link
Contributor Author

Ionaru commented Oct 23, 2019

The test TestFuturizeSimple::test_input_without_import fails on Py26, I don't know why.
@jmadler @anikamukherji any idea?

I wouldn't be against dropping Py26 support with #496 though 😛

@jmadler
Copy link
Contributor

jmadler commented Oct 24, 2019

@Ionaru - The failure looks unrelated. I'd prefer we not drop Py26 support until absolutely necessary.

I'll merge it in and follow-up on the Py26 test failure.

@jmadler jmadler merged commit 615ee1e into PythonCharmers:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

raw_input breaking with multiple futurize passes

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.