use object.setattr to bypass check for immutable objects#518
Merged
jmadler merged 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom Oct 24, 2019
anikamukherji:immutable-causesanikamukherji/python-future:immutable-causesCopy head branch name to clipboard
Merged
use object.setattr to bypass check for immutable objects#518jmadler merged 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom anikamukherji:immutable-causesanikamukherji/python-future:immutable-causesCopy head branch name to clipboard
jmadler merged 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
anikamukherji:immutable-causesanikamukherji/python-future:immutable-causesCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using object.setattr will bypass the setattr check in the class of the exception, and execute the setattr on the base class. This will prevent this from throwing TypeErrors when exceptions are from immutable classes.