Fix min/max functions with generators, and 'None' default#514
Merged
jmadler merged 5 commits intoPythonCharmers:masterPythonCharmers/python-future:masterfrom Oct 24, 2019
Merged
Fix min/max functions with generators, and 'None' default#514jmadler merged 5 commits intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
jmadler merged 5 commits intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
Conversation
Contributor
Author
|
Oops, didn't see we already had some tests in test_builtins. I'll just add the appropriate new tests there. |
a6b1b8a to
f60f672
Compare
Contributor
Author
|
A couple more changes crept into this PR, updated the original PR text to reflect this. |
Contributor
Author
|
Not sure why travis isn't adding the results here, pretty sure the 2.6 failures have nothing to do with this PR though. https://travis-ci.org/PythonCharmers/python-future/builds/599676065 |
Contributor
|
I can confirm this fixes an issue for me which looks like what is described in #510 first post, see #510 (comment). I recommend merging and releasing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I allowed a few fixes to creep into this PR, I can separate them out if desired. This PR addresses:
Noneas a default.