Fix urllib.request imports#382
Closed
yan12125 wants to merge 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
yan12125:fix-urllib-request-importsCopy head branch name to clipboard
Closed
Fix urllib.request imports#382yan12125 wants to merge 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom yan12125:fix-urllib-request-importsCopy head branch name to clipboard
yan12125 wants to merge 1 commit intoPythonCharmers:masterPythonCharmers/python-future:masterfrom
yan12125:fix-urllib-request-importsCopy head branch name to clipboard
Conversation
Contributor
Author
|
I created this pull request to make buildbot compatible with Python 3.8. Now buildbot is going to drop Python 2 support and remove usage of python-future [1], so the issue is no longer relevant. Feel free to take my patch if anyone else want to continue the work. |
This was referenced Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350