Reduce callproc roundtrip time #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make only one single call to SET variables used as procedure parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Equivalent of PyMySQL/PyMySQL#636, for this module.)
Rather than making an individual SET query for each and every parameter specified for a callproc call, use one single call instead, saving round-trip time (if one has more than one parameter). This can be significant if one is making many repeated callproc calls which have multiple arguments.
Then only downside I can think of is that if one or more arguments are quite large, combining them all could hit the max_allowed_packet limit. However, if it is only e.g. one large argument this will make next to no difference and the user should have an increased max_allowed_packet value in anticipation of e.g. larger blobs already.