Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9c1b0d8

Browse filesBrowse files
authored
Reduce callproc roundtrip time (#636)
Make only one single call to SET variables used as procedure parameters
2 parents 9f29c16 + 3dda4a5 commit 9c1b0d8
Copy full SHA for 9c1b0d8

File tree

Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎pymysql/cursors.py‎

Copy file name to clipboardExpand all lines: pymysql/cursors.py
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,9 +262,10 @@ def callproc(self, procname, args=()):
262262
disconnected.
263263
"""
264264
conn = self._get_db()
265-
for index, arg in enumerate(args):
266-
q = "SET @_%s_%d=%s" % (procname, index, conn.escape(arg))
267-
self._query(q)
265+
if args:
266+
fmt = '@_{0}_%d=%s'.format(procname)
267+
self._query('SET %s' % ','.join(fmt % (index, conn.escape(arg))
268+
for index, arg in enumerate(args)))
268269
self.nextset()
269270

270271
q = "CALL %s(%s)" % (procname,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.