-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add Unit Tests for GetDateTest.cs and StartSleepTest.cs #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andschwa , could you please help to merge this to master, thanks. |
|
@JamesWTruher Please review and merge. |
test/powershell/Get-Date.Tests.ps1
Outdated
|
|
||
| It "using -displayhint produces the correct output" { | ||
| $newLine = [Environment]::NewLine | ||
| Get-date -Date:"Jan 1, 2020" -DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date) | Out-String | Should be $newLine"Wednesday, January 1, 2020$newLine$newLine$newLine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-DisplayHint:$([Microsoft.PowerShell.Commands.DisplayHintType]::Date)
should just be:
-DisplayHint Date
Also, I'd be happier if this was
$d = get-date -date "Jan 1, 2020" -DisplayHint Date | out-string
$d.Trim() | should be "Wednesday, January 1, 2020"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
LGTM. |
|
🎉This issue was addressed in #10017, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9954, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9885, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9875, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9862, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9854, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9843, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #9805, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #10364, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #10421, which has now been successfully released as Handy links: |
Please help to review, thanks!
This change is