From 324c04740ae51a13a257257b9db7c5b54ed7a86f Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Sun, 25 Jun 2017 12:28:26 -0700 Subject: [PATCH 1/6] remove references to localaccount in opencover --- test/tools/OpenCover/OpenCover.psm1 | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/tools/OpenCover/OpenCover.psm1 b/test/tools/OpenCover/OpenCover.psm1 index a19aa33b18a..df2b77a1063 100644 --- a/test/tools/OpenCover/OpenCover.psm1 +++ b/test/tools/OpenCover/OpenCover.psm1 @@ -232,7 +232,6 @@ function Expand-ZipArchive([string] $Path, [string] $DestinationPath) Microsoft.PowerShell.PackageManagement 59.77 62.04 Branch:59.77 Sequence:62.04 Microsoft.PackageManagement 41.73 44.47 Branch:41.73 Sequence:44.47 Microsoft.Management.Infrastructure.CimCmdlets 13.20 17.01 Branch:13.20 Sequence:17.01 - Microsoft.PowerShell.LocalAccounts 73.15 84.32 Branch:73.15 Sequence:84.32 Microsoft.PackageManagement.MetaProvider.PowerShell 54.79 57.90 Branch:54.79 Sequence:57.90 Microsoft.PackageManagement.NuGetProvider 62.36 65.37 Branch:62.36 Sequence:65.37 Microsoft.PackageManagement.CoreProviders 7.08 7.96 Branch:7.08 Sequence:7.96 @@ -285,7 +284,6 @@ function Get-CodeCoverage Microsoft.PowerShell.ConsoleHost 36.53 0 38.40 0 Microsoft.PowerShell.CoreCLR.AssemblyLoadContext 53.66 0 95.31 0 Microsoft.PowerShell.CoreCLR.Eventing 28.70 0 36.23 0 - Microsoft.PowerShell.LocalAccounts 73.15 0 84.32 0 Microsoft.PowerShell.PackageManagement 59.77 0 62.04 0 Microsoft.PowerShell.PSReadLine 7.12 0 9.94 0 Microsoft.PowerShell.Security 15.17 0 18.16 0 @@ -312,7 +310,6 @@ function Get-CodeCoverage Microsoft.PowerShell.ConsoleHost 36.53 0 38.40 0 Microsoft.PowerShell.CoreCLR.AssemblyLoadContext 53.66 0 95.31 0 Microsoft.PowerShell.CoreCLR.Eventing 28.70 0 36.23 0 - Microsoft.PowerShell.LocalAccounts 73.15 0 84.32 0 Microsoft.PowerShell.PackageManagement 59.77 0 62.04 0 Microsoft.PowerShell.PSReadLine 7.12 0 9.94 0 Microsoft.PowerShell.Security 15.17 0 18.16 0 From fe24900d7b5c577b7e5f9c861e2b59ca3b862783 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 17 Jul 2017 10:44:56 -0700 Subject: [PATCH 2/6] move module to full --- .../LocalAccounts.format.ps1xml | 0 .../Microsoft.PowerShell.LocalAccounts.psd1 | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename src/Modules/{Windows-Core+Full => Windows-Full}/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml (100%) rename src/Modules/{Windows-Core+Full => Windows-Full}/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 (100%) diff --git a/src/Modules/Windows-Core+Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml b/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml similarity index 100% rename from src/Modules/Windows-Core+Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml rename to src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml diff --git a/src/Modules/Windows-Core+Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 b/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 similarity index 100% rename from src/Modules/Windows-Core+Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 rename to src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 From fc01838744d3669c137a6f20e9f6cace58950a8c Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 17 Jul 2017 10:48:48 -0700 Subject: [PATCH 3/6] remove local accounts updatable help tests --- test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 b/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 index 6911d7b7bc1..b7060e751ae 100644 --- a/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 +++ b/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 @@ -12,7 +12,7 @@ $powershellCoreModules = @( "Microsoft.PowerShell.Core" "Microsoft.PowerShell.Diagnostics" "Microsoft.PowerShell.Management" - "Microsoft.PowerShell.LocalAccounts" + # "Microsoft.PowerShell.LocalAccounts" removed due to #4274 "Microsoft.PowerShell.Security" "Microsoft.PowerShell.Utility" "Microsoft.WsMan.Management" From ad33306a0bd19b7dd59498d9ed8cdf5d1924ce3b Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 17 Jul 2017 10:50:45 -0700 Subject: [PATCH 4/6] remove local account from BOM tests --- test/fullclr/PowerShellGithubDev.Tests.ps1 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/fullclr/PowerShellGithubDev.Tests.ps1 b/test/fullclr/PowerShellGithubDev.Tests.ps1 index b24b6e6fba0..611fa0de6d9 100644 --- a/test/fullclr/PowerShellGithubDev.Tests.ps1 +++ b/test/fullclr/PowerShellGithubDev.Tests.ps1 @@ -48,6 +48,8 @@ try # this Describe makes sure we binplace all the files, like psd1, psm1, ps1xml and load usable modules from them Describe 'Modules for the package' { Context '$env:DEVPATH Modules loading' { + <# + removed due to #4272 It 'loads Microsoft.PowerShell.LocalAccounts' { try { @@ -59,6 +61,7 @@ try Remove-Module -ErrorAction SilentlyContinue Microsoft.PowerShell.LocalAccounts } } + #> It 'loads Microsoft.PowerShell.Archive' { try From 88d95e060312033c8023d47c2fff931f390d6ab8 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 17 Jul 2017 10:53:32 -0700 Subject: [PATCH 5/6] disable local account tests --- ...Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 | 5 +++++ ....Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 | 5 +++++ .../Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 | 5 +++++ 3 files changed, 15 insertions(+) diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 index e0b093ecd4d..507f3e9d109 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 @@ -2,6 +2,11 @@ # # Copyright (c) Microsoft Corporation, 2015 +# Module removed due to #4272 +# disabling tests + +return + function RemoveTestGroups { param([string] $basename) diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 index e182a993cc5..c6fb3f5a373 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 @@ -2,6 +2,11 @@ # # Copyright (c) Microsoft Corporation, 2015 +# Module removed due to #4272 +# disabling tests + +return + function IsWin10OrHigher { $version = [system.environment]::osversion.version diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 index d0bee20c426..e3d4077b34c 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 @@ -2,6 +2,11 @@ # # Copyright (c) Microsoft Corporation, 2015 +# Module removed due to #4272 +# disabling tests + +return + Set-Variable dateInFuture -option Constant -value "12/12/2036 09:00" Set-Variable dateInPast -option Constant -value "12/12/2010 09:00" Set-Variable dateInvalid -option Constant -value "12/12/2016 25:00" From 3ee44df134c20de945192db96f93c18816dc89e0 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 17 Jul 2017 10:58:42 -0700 Subject: [PATCH 6/6] remove local accounts from the build [Feature]-2 --- build.psm1 | 1 - src/powershell-win-core/powershell-win-core.csproj | 1 - 2 files changed, 2 deletions(-) diff --git a/build.psm1 b/build.psm1 index 12e70251cdb..4d63ecff3fb 100644 --- a/build.psm1 +++ b/build.psm1 @@ -2961,7 +2961,6 @@ function Start-CrossGen { $psCoreAssemblyList += @( "Microsoft.WSMan.Management.dll", "Microsoft.WSMan.Runtime.dll", - "Microsoft.PowerShell.LocalAccounts.dll", "Microsoft.PowerShell.Commands.Diagnostics.dll", "Microsoft.Management.Infrastructure.CimCmdlets.dll" ) diff --git a/src/powershell-win-core/powershell-win-core.csproj b/src/powershell-win-core/powershell-win-core.csproj index 75dcc0d1cc8..cfd3b498880 100644 --- a/src/powershell-win-core/powershell-win-core.csproj +++ b/src/powershell-win-core/powershell-win-core.csproj @@ -33,7 +33,6 @@ -