From e75fee16ed272551317464033d9aac711f6e001a Mon Sep 17 00:00:00 2001 From: Tadas Date: Sat, 17 Jun 2017 01:22:08 +0100 Subject: [PATCH 1/2] Start-Sleep: add 'ms' alias --- .../commands/utility/StartSleepCommand.cs | 1 + .../Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/StartSleepCommand.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/StartSleepCommand.cs index 72e1ec4e3b1..8006470e231 100644 --- a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/StartSleepCommand.cs +++ b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/StartSleepCommand.cs @@ -54,6 +54,7 @@ public void Dispose() /// [Parameter(Mandatory = true, ParameterSetName = "Milliseconds", ValueFromPipelineByPropertyName = true)] [ValidateRangeAttribute(0, int.MaxValue)] + [Alias("ms")] public int Milliseconds { get; set; } #endregion diff --git a/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 index ed0766ac7db..f3bacb9d6e3 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 @@ -17,6 +17,13 @@ Describe "Start-Sleep DRT Unit Tests" -Tags "CI" { $watch.Stop() $watch.ElapsedMilliseconds | Should BeGreaterThan 950 } + + It "Should work properly when sleeping with ms alias" { + $watch = [System.Diagnostics.Stopwatch]::StartNew() + Start-Sleep -ms 1000 + $watch.Stop() + $watch.ElapsedMilliseconds | Should BeGreaterThan 950 + } } Describe "Start-Sleep" -Tags "CI" { From 2a42f0b65f5f2c4171e0ac41fe697b34801ff3b1 Mon Sep 17 00:00:00 2001 From: Tadas Date: Sat, 17 Jun 2017 11:23:17 +0100 Subject: [PATCH 2/2] Add BeLessThan tests --- .../Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 index f3bacb9d6e3..a67eaaa8683 100644 --- a/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 +++ b/test/powershell/Modules/Microsoft.PowerShell.Utility/Start-Sleep.Tests.ps1 @@ -9,6 +9,7 @@ Describe "Start-Sleep DRT Unit Tests" -Tags "CI" { Start-Sleep -Seconds 1 $watch.Stop() $watch.ElapsedMilliseconds | Should BeGreaterThan 950 + $watch.ElapsedMilliseconds | Should BeLessThan 1050 } It "Should work properly when sleeping with Milliseconds" { @@ -16,6 +17,7 @@ Describe "Start-Sleep DRT Unit Tests" -Tags "CI" { Start-Sleep -Milliseconds 1000 $watch.Stop() $watch.ElapsedMilliseconds | Should BeGreaterThan 950 + $watch.ElapsedMilliseconds | Should BeLessThan 1050 } It "Should work properly when sleeping with ms alias" { @@ -23,6 +25,7 @@ Describe "Start-Sleep DRT Unit Tests" -Tags "CI" { Start-Sleep -ms 1000 $watch.Stop() $watch.ElapsedMilliseconds | Should BeGreaterThan 950 + $watch.ElapsedMilliseconds | Should BeLessThan 1050 } }