-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update script to pin to .NET 7 preview 5 version #17448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update script to pin to .NET 7 preview 5 version #17448
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
|
||
| Write-Verbose -Verbose -Message "Updating DotnetRuntimeMetadata.json with channel $newChannel" | ||
|
|
||
| # Transform SDK Version '7.0.100-preview.5.22263.22' -> '7.0.100-preview.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there supposed to be inconsistency between 7.0.1xx-preview5 and 7.0.100-preview.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. the one with xx is for the SDK and the other is for nuget packages.
| "packageVersionPattern": "7.0.0-preview.5", | ||
| "sdkImageVersion": "7.0.100", | ||
| "nextChannel": "7.0.1xx", | ||
| "nextChannel": "7.0.1xx-preview5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we will need to update this file when done with a preview release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, unfortunately the auto update will get the next version. currently that will be preview 6. So, we have to pin to a version we want.
|
🎉 Handy links: |
PR Summary
Pin the next channel version to preview 5 so we do not get preview 6 builds.
Update the package version pattern in dotnetruntimemetadata.json
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).