Fix the error message in Hashtable-to-object conversion#17329
Merged
daxian-dbw merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom May 16, 2022
Merged
Fix the error message in Hashtable-to-object conversion#17329daxian-dbw merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom
Conversation
iSazonov
approved these changes
May 13, 2022
Member
|
/rebase |
SteveL-MSFT
reviewed
May 16, 2022
test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1
Outdated
Show resolved
Hide resolved
SeeminglyScience
approved these changes
May 16, 2022
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the error message in Hashtable-to-object conversion.
In Hashtable-to-object conversion, when a key in the Hashtable cannot be found as a settable property in the convert-to type, the error message calls out all property information including the read-only ones. Since Hashtable-to-object conversion can only work for settable properties, the error message should only call out the settable properties.
Run
[System.Collections.Specialized.OrderedDictionary]@{a = 1}as an example to demonstrate:Before the change, the error message calls out all properties, even though all are read-only:
After the change, the error message says "no settable property available" when there is no settable property:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.