-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix the error message in Hashtable-to-object conversion #17329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/rebase |
test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Language/Scripting/HashtableToPSCustomObjectConversion.Tests.ps1
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
Fix the error message in Hashtable-to-object conversion.
In Hashtable-to-object conversion, when a key in the Hashtable cannot be found as a settable property in the convert-to type, the error message calls out all property information including the read-only ones. Since Hashtable-to-object conversion can only work for settable properties, the error message should only call out the settable properties.
Run
[System.Collections.Specialized.OrderedDictionary]@{a = 1}as an example to demonstrate:Before the change, the error message calls out all properties, even though all are read-only:
After the change, the error message says "no settable property available" when there is no settable property:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.