Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@adityapatwardhan
Copy link
Member

PR Summary

  • Update dotnetmetadata.json to accept .NET 7 preview 3 nightly builds
  • Update Microsoft.CSharp version in Microsoft.PowerShell.NamedPipeConnection.csproj
  • Add a catch for version which do not support SematicVersion
  • Make TLS10 and TLS 1.1 default to TLS1.2 as it is a breaking change in .NET. They are marked as obsolete.

PR Context

PR Checklist

Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"nextChannel": "7.0.1xx-preview3",
"azureFeed": "",
"sdkImageOverride": "7.0.100-preview.2.22153.17"
"sdkImageOverride": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we still need the same in global.json? Weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the GitHub workflow that updates the build stick to this specific version. If we keep this here, we will never get daily updates. The value is global.json is the one we are building against.

@TravisEz13 TravisEz13 merged commit 9fc0e80 into PowerShell:master Mar 25, 2022
@adityapatwardhan adityapatwardhan deleted the UpdateMetadata7p3 branch March 25, 2022 23:15
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.