-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update dotnetmetadata.json to accept .NET 7 preview 3 builds
#17063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnetmetadata.json to accept .NET 7 preview 3 builds
#17063
Conversation
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "nextChannel": "7.0.1xx-preview3", | ||
| "azureFeed": "", | ||
| "sdkImageOverride": "7.0.100-preview.2.22153.17" | ||
| "sdkImageOverride": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still need the same in global.json? Weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the GitHub workflow that updates the build stick to this specific version. If we keep this here, we will never get daily updates. The value is global.json is the one we are building against.
|
🎉 Handy links: |
PR Summary
dotnetmetadata.jsonto accept .NET 7 preview 3 nightly buildsMicrosoft.CSharpversion in Microsoft.PowerShell.NamedPipeConnection.csprojPR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).