Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add mariner 1.0 amd64 package #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 27 commits into from
Mar 25, 2022
Merged

Add mariner 1.0 amd64 package #17057

TravisEz13 merged 27 commits into from
Mar 25, 2022

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Mar 23, 2022

PR Summary

PR Context

PR Checklist

TravisEz13 and others added 26 commits March 21, 2022 14:03
@TravisEz13
add mariner package
b397919
@TravisEz13
update signing
17e7301
@TravisEz13
update template branch
ceb4874
@TravisEz13
Don't overwrite signed files
983fd77
@TravisEz13
use nevercopy
0020ec4
@TravisEz13
update bom tests to support rpm
837b62e
@TravisEz13
switch to new output mode param
43cd529
@TravisEz13
more complex copy strategy
fe306a0
@TravisEz13
change mariner distribution name
8a00d77
@TravisEz13
Fix dependecies
12dcf46
@TravisEz13
add error details
9da59c4
@TravisEz13
fix variable name
b019050
@TravisEz13
fix all distribution
c41383d
@TravisEz13
fix macos packaging error
fbc8462
@TravisEz13
add diags
cf895c4
@TravisEz13
fix macos
93cddea
@TravisEz13
fix package name validation
8cc0cf7
@TravisEz13
check boms on ubuntu
e79cf86
@TravisEz13
pend tests if rpm2cpio doesn't exist
9554aa8
@TravisEz13
Revert "check boms on ubuntu"
5c8bdd4 
This reverts commit e79cf86.
@TravisEz13
use download task instead of azCopy
3c0197c
@TravisEz13
Use ubuntu again
c73de29
@TravisEz13
filter symbol packages
165442a
@TravisEz13
fix rpm test
2f3af84
@TravisEz13
Get correct pshome
1538bdb
@TravisEz13
skip hash check on
0e6798f
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Mar 23, 2022

This PR has 242 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +162 -80
Percentile : 64.2%

Total files changed: 8

Change summary by file extension:
.psm1 : +40 -10
.ps1 : +65 -38
.yml : +57 -32

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

TravisEz13
TravisEz13 commented Mar 24, 2022
View reviewed changes
tools/releaseBuild/azureDevOps/releaseBuild.yml Outdated Show resolved Hide resolved
@TravisEz13 TravisEz13 merged commit dc0eff2 into PowerShell:master Mar 25, 2022
@TravisEz13 TravisEz13 deleted the mariner branch March 25, 2022 20:50
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13
Copy link
Member Author

TravisEz13 commented May 23, 2022

/backport to release/v7.2.5

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022 •
edited by unfurl-links bot
Loading

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2374308271

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

@TravisEz13 backporting to release/v7.2.5 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: add mariner package
Using index info to reconstruct a base tree...
M	tools/packaging/packaging.psm1
Falling back to patching base and 3-way merge...
Auto-merging tools/packaging/packaging.psm1
CONFLICT (content): Merge conflict in tools/packaging/packaging.psm1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add mariner package
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request May 23, 2022
@TravisEz13
Add mariner 1.0 amd64 package (PowerShell#17057)
5d9789e 
* add mariner package

* update signing

* update template branch

* Don't overwrite signed files

* use nevercopy

* update bom tests to support rpm

* switch to new output mode param

* more complex copy strategy

* change mariner distribution name

* Fix dependecies

* add error details

* fix variable name

* fix all distribution

* fix macos packaging error

* add diags

* fix macos

* fix package name validation

* check boms on ubuntu

* pend tests if rpm2cpio doesn't exist

* Revert "check boms on ubuntu"

This reverts commit e79cf86.

* use download task instead of azCopy

* Use ubuntu again

* filter symbol packages

* fix rpm test

* Get correct pshome

* skip hash check on

* Update tools/releaseBuild/azureDevOps/releaseBuild.yml
# Conflicts:
#	tools/packaging/packaging.psm1
@TravisEz13 TravisEz13 mentioned this pull request May 23, 2022
Merged
adityapatwardhan pushed a commit that referenced this pull request May 24, 2022
@TravisEz13
Base work for adding mariner amd64 package (#17417)
3cfa8eb 
Backport #17057
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TravisEz13 @adityapatwardhan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.