-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update Images used for release #16580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b983ea2 to
913bbb6
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - changes are the same just rebased to fix test failures.
|
🎉 Handy links: |
# Conflicts: # tools/releaseBuild/azureDevOps/releasePipeline.yml # tools/releaseBuild/azureDevOps/templates/release-MsixBundle.yml # tools/releaseBuild/azureDevOps/templates/release-ValidateFxdPackage.yml # tools/releaseBuild/azureDevOps/templates/testartifacts.yml # tools/releaseBuild/azureDevOps/vpackRelease.yml
# Conflicts: # tools/releaseBuild/azureDevOps/releasePipeline.yml # tools/releaseBuild/azureDevOps/templates/release-MsixBundle.yml # tools/releaseBuild/azureDevOps/templates/release-ValidateFxdPackage.yml # tools/releaseBuild/azureDevOps/templates/testartifacts.yml # tools/releaseBuild/azureDevOps/vpackRelease.yml
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Update Images used for release
PR Context
Release (build and release portions) must use TLS and we are changing to images that enforce that.
Also, add comments for
vmImageuse which are testing. At those places, it is okay to use Microsoft Hosted pools.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).