Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Mark private members as static part 10#14235

Merged
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:CA1822-p10xtqqczze/PowerShell-PowerShell:CA1822-p10Copy head branch name to clipboard
Nov 27, 2020
Merged

Mark private members as static part 10#14235
iSazonov merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:CA1822-p10xtqqczze/PowerShell-PowerShell:CA1822-p10Copy head branch name to clipboard

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

src\System.Management.Automation\
-src\System.Management.Automation\engine\

Contributes to #13897.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822

`src\System.Management.Automation\`
-`src\System.Management.Automation\engine\`

Contributes to PowerShell#13897.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
@xtqqczze

Copy link
Copy Markdown
Contributor Author

CodeFactor "Complex Method" issues are preexisting.

@iSazonov

Copy link
Copy Markdown
Collaborator

@xtqqczze Please resolve merge conflicts.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 26, 2020
@iSazonov

iSazonov commented Nov 26, 2020

Copy link
Copy Markdown
Collaborator

@xtqqczze

xtqqczze commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

CI static fails on https://www.codefactor.io/

HTTP Error 500.31 - Failed to load ASP.NET Core runtime

Tracking issue opened: #14269.

@iSazonov

iSazonov commented Nov 26, 2020

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 27, 2020
@iSazonov iSazonov merged commit 8d48693 into PowerShell:master Nov 27, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 27, 2020
@xtqqczze xtqqczze deleted the CA1822-p10 branch November 27, 2020 15:52
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.