Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@xtqqczze
Copy link
Contributor

PR Summary

Fix using new AvoidUsingDoubleQuotesForConstantString PSScriptAnalyzer rule

PR Context

PowerShell/PSScriptAnalyzer#1470

PR Checklist

Fix using new AvoidUsingDoubleQuotesForConstantString PSScriptAnalyzer rule
@ghost ghost assigned iSazonov Jul 31, 2020
@daxian-dbw daxian-dbw added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Aug 1, 2020
@xtqqczze xtqqczze marked this pull request as ready for review August 1, 2020 17:02
@TravisEz13
Copy link
Member

TravisEz13 commented Aug 4, 2020

@PowerShell/powershell-maintainers discussed this and concluded:

This is an information rule. Purely an opinion, clearly by the number of changes required, we have not consensus. So, this rule should be considered, disabled. Furthermore, this PR should not be taken.
https://github.com/PowerShell/PSScriptAnalyzer/blob/master/RuleDocumentation/AvoidUsingDoubleQuotesForConstantString.md

GitHub
Download ScriptAnalyzer from PowerShellGallery. Contribute to PowerShell/PSScriptAnalyzer development by creating an account on GitHub.

@TravisEz13 TravisEz13 removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Aug 4, 2020
@xtqqczze xtqqczze closed this Aug 4, 2020
@xtqqczze xtqqczze deleted the AvoidUsingDoubleQuotesForConstantString branch August 4, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.