Reinstate debugging API lost in #10338 #10808
Conversation
PaulHigin
left a comment
There was a problem hiding this comment.
LGTM, except I feel we should use the newer style for the overrides.
There was a problem hiding this comment.
@rjmholt, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/building/internals.md.https://cmake.org/download/ should work
retry of URL failed with error: Response status code does not indicate success: 500 (Internal Server Error).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 117
117: throw "retry of URL failed with error: $($_.Exception.Message)"
There was a problem hiding this comment.
@rjmholt, your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 127|
@rjmholt Please rebase to pass CIs. |
b8f8ced to
4b796e8
Compare
There was a problem hiding this comment.
@rjmholt, your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 127There was a problem hiding this comment.
@rjmholt, your last commit had 1 failures in PowerShell-CI-windows
TestAppDomainProcessExitEvenHandlerNotLeaking
Assert.DoesNotContain() Failure
Found: (filter expression)
In value: Delegate[] [EventHandler { Method = Void DisposeOnShutdown(System.Object, System.EventArgs), Target = null }, EventHandler { Method = Void CurrentDomain_ProcessExit(System.Object, System.EventArgs), Target = null }]
at PSTests.Sequential.RunspaceTests.TestAppDomainProcessExitEvenHandlerNotLeaking() in D:\a\1\s\test\xUnit\csharp\test_Runspace.cs:line 1274b796e8 to
af70d02
Compare
|
@rjmholt Please fix the code factor reported issues. |
Remaining issues are as they were in the codebase before the API was taken out. |
|
🎉 Handy links: |
PR Summary
Adds SetBreakpoints back
PR Context
#10338 removed the
SetBreakpointspublic API, which is required for cross-PowerShell debugging.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.