Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@MatejKafka
Copy link
Contributor

@MatejKafka MatejKafka commented Feb 11, 2025

PR Summary

Fixes grouping of Pester tests where tests for -ReportSummary and a few other parameters were (probably accidentally) nested inside another Describe block. Recommend reviewing the diff locally, GitHub diff rendering is very confused (the commit just removes a level of indentation and moves a single }).

PR Checklist

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, you're quite right. Thanks!

@andyleejordan andyleejordan changed the title Fix incorrect Invoke-ScriptAnalyzer Pester test grouping Fix incorrect -ReportSummary Pester test grouping Feb 11, 2025
@andyleejordan andyleejordan enabled auto-merge (squash) February 11, 2025 20:14
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted CI check, if that's green, happy with it

@andyleejordan andyleejordan merged commit 03beb17 into PowerShell:main Feb 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.