UseUsingScopeModifierInNewRunspaces: Fix ArgumentException when the same variable name is used in 2 different sessions. #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame variable name is used in 2 different sessions.
bergmeister
commented
May 12, 2020
rjmholt
approved these changes
May 12, 2020
|
@bergmeister @rjmholt do you know when this will be added to a release? |
Collaborator
Author
|
@scott1138 We hope to release this next month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1492 by checking if the variable name was already added. Also simplifying the code to be a
HashSet<string>instead of aDictionary<string,VariableExpressionAst>since the actual variable seems to be never used. Unfortunately I have to drop theIReadOnlyCollectionforHashSetsince we target .Net 4.5.2 and only starting with .Net 4.6,HashSetis implementingIReadOnlyCollection, see here.cc @Jawz84
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.