Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Sep 30, 2025

closes #325

  • migrates old JSON format to new PGM JSON serialization format
  • resolves pandas deprecation warning by not concatinating empty data frames

TODO:

  • verify / test backwards compatibility (do-not-merge label)
    • the changes are indeed backwards compatible, because the "tricky" part only affects test code

To validate (reviewer):

  • verify deprecation warnings on main
    • checkout main
    • editable install including dev dependencies
    • pytest does not result in deprecation warnings
    • pytest tests/validation results in deprecation warnings
  • verify deprecation warnings fixed on this branch
    • checkout this branch
    • editable install including dev dependencies
    • pytest does not result in deprecation warnings
    • pytest tests/validation does not result in deprecation warnings

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers self-assigned this Sep 30, 2025
@mgovers mgovers added python Pull requests that update python code do-not-merge This should not be merged labels Sep 30, 2025
@mgovers mgovers marked this pull request as draft September 30, 2025 08:16
@mgovers
Copy link
Member Author

mgovers commented Sep 30, 2025

Backwards compatibility only affects tests. removing do-not-merge label

@mgovers mgovers removed the do-not-merge This should not be merged label Sep 30, 2025
@mgovers mgovers marked this pull request as ready for review October 9, 2025 13:17
mgovers and others added 2 commits October 13, 2025 10:27
Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
tests/validation/utils.py Show resolved Hide resolved
@nitbharambe
Copy link
Member

Rest of the changes look good.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Copy link

@mgovers mgovers added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit c145eef Oct 17, 2025
37 checks passed
@mgovers mgovers deleted the feature/resolve-validation-test-warnings branch October 17, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Resolve warnings from tests (And classify them as error after)

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.