MINOR: Set a prefix in the logger#150
Open
stanislavkozlovski wants to merge 1 commit intoPostHog:masterPostHog/posthog-python:masterfrom
Open
MINOR: Set a prefix in the logger#150stanislavkozlovski wants to merge 1 commit intoPostHog:masterPostHog/posthog-python:masterfrom
stanislavkozlovski wants to merge 1 commit intoPostHog:masterPostHog/posthog-python:masterfrom
Conversation
The `posthog` logger would log without a prefix, which would cause confusion with users of the library. This patch adds a simple prefix to the log message - the new format is `[posthog] <MSG>`
Member
|
We've updated our release process. We require |
dustinbyrne
reviewed
Feb 20, 2026
Comment on lines
+931
to
+934
| handler = logging.StreamHandler() | ||
| handler.setFormatter(logging.Formatter('[%(name)s] %(message)s')) | ||
| log.addHandler(handler) | ||
| log.propagate = False # Prevents double logging (otherwise we'd have an extra log that doesn't use the handler) |
Contributor
There was a problem hiding this comment.
Nice! This is a much cleaner log statement.
There are a couple of blocking issues here:
logisn't qualified correctly - running this this would raise an exception- Because
logis defined at the class level, multiple instances ofClientwill accumulate handlers and duplicate log messages.
Finally, I think it's worth including the log level in the formatter.
Suggested change
| handler = logging.StreamHandler() | |
| handler.setFormatter(logging.Formatter('[%(name)s] %(message)s')) | |
| log.addHandler(handler) | |
| log.propagate = False # Prevents double logging (otherwise we'd have an extra log that doesn't use the handler) | |
| if not self.log.handlers: | |
| handler = logging.StreamHandler() | |
| handler.setFormatter(logging.Formatter("[%(name)s] %(levelname)s - %(message)s")) | |
| self.log.addHandler(handler) | |
| self.log.propagate = False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149