fix(surveys): android keyboard glitching #2809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
954fe44 to
47fd005
Compare
| behavior={Platform.OS === 'ios' ? 'padding' : 'height'} | ||
| behavior={Platform.OS === 'ios' ? 'padding' : androidKeyboardBehavior} | ||
| style={{ flex: 1, justifyContent: 'flex-end' }} | ||
| keyboardVerticalOffset={Platform.OS === 'ios' ? 10 : 0} |
Contributor
There was a problem hiding this comment.
style: keyboardVerticalOffset hardcoded to 0 for Android. When using 'padding' behavior, a non-zero offset may be needed for proper spacing (similar to iOS). Consider making this configurable or using a conditional offset based on the behavior type.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react-native/src/surveys/components/SurveyModal.tsx
Line: 45:45
Comment:
**style:** `keyboardVerticalOffset` hardcoded to 0 for Android. When using `'padding'` behavior, a non-zero offset may be needed for proper spacing (similar to iOS). Consider making this configurable or using a conditional offset based on the behavior type.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Contributor
|
Size Change: +207 B (0%) Total Size: 5.33 MB
ℹ️ View Unchanged
|
ioannisj
approved these changes
Dec 23, 2025
Contributor
ioannisj
left a comment
There was a problem hiding this comment.
Approved to unblock you and the customer. Would prefer though we validate with them that this will work first since it seems we've been deliberately setting height before
| return ( | ||
| <Modal animationType="fade" transparent onRequestClose={onClose} statusBarTranslucent={true}> | ||
| <KeyboardAvoidingView | ||
| behavior={Platform.OS === 'ios' ? 'padding' : 'height'} |
Contributor
There was a problem hiding this comment.
Looks like we were deliberately setting height for Android. Wonder what the original reason was but @marandaneto is OOO
Contributor
Author
There was a problem hiding this comment.
yeah good question, i was trying to find out but didn't get very far
as far as i can tell it's always been like that, and i think the bug we are seeing is related to this facebook/react-native#45192, but still not 100% sure
i asked the customer if they'd be able to pull our branch for testing so i can hang tight on merging until i hear back from her on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
the keyboard causes major glitching in some cases on android. customer video here: https://posthoghelp.zendesk.com/agent/tickets/44614
reproduction here, on android 16 with physical keyboard + stylus input modes enabled:
Screen Recording 2025-12-22 at 12.53.23 PM.mov (uploaded via Graphite)
Changes
adds a new sdk param
androidKeyboardBehaviorto control the behavior forKeyboardAvoidingViewon androidsetting it to
paddingresolved the issue in my testing, but i do not want to risk a regression hereRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file