fix bug where form would be submitted on select#87
Open
KarolineKarkosch wants to merge 1 commit intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom
KarolineKarkosch:bugfix/dont-submit-form-on-selectKarolineKarkosch/JavaScript-autoComplete:bugfix/dont-submit-form-on-selectCopy head branch name to clipboard
Open
fix bug where form would be submitted on select#87KarolineKarkosch wants to merge 1 commit intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom KarolineKarkosch:bugfix/dont-submit-form-on-selectKarolineKarkosch/JavaScript-autoComplete:bugfix/dont-submit-form-on-selectCopy head branch name to clipboard
KarolineKarkosch wants to merge 1 commit intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom
KarolineKarkosch:bugfix/dont-submit-form-on-selectKarolineKarkosch/JavaScript-autoComplete:bugfix/dont-submit-form-on-selectCopy head branch name to clipboard
Conversation
When the input of the autocomplete is inside a form and the user selects an option currently the form is instantly being submitted. When selecting an option with enter, the form should not be submitted. (After selecting an option enter still can be used to submit the form)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the input of the autocomplete is inside a form and the user selects an option (with arrow keys and enter) currently the form is instantly being submitted. When selecting an option with enter, the form should not be submitted.
(After an option was selected enter can still be used to submit the form)
@SimonSteinberger small suggestion that might improve your lib