Improvement/code optimization#21
Open
mertenhanisch wants to merge 4 commits intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom
mertenhanisch:improvement/code-optimizationmertenhanisch/JavaScript-autoComplete:improvement/code-optimizationCopy head branch name to clipboard
Open
Improvement/code optimization#21mertenhanisch wants to merge 4 commits intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom mertenhanisch:improvement/code-optimizationmertenhanisch/JavaScript-autoComplete:improvement/code-optimizationCopy head branch name to clipboard
mertenhanisch wants to merge 4 commits intoPixabay:masterPixabay/JavaScript-autoComplete:masterfrom
mertenhanisch:improvement/code-optimizationmertenhanisch/JavaScript-autoComplete:improvement/code-optimizationCopy head branch name to clipboard
Conversation
there are still some closure problems, specificly in the suggest func
and because Plankalkuel is awesome
TheKidCoder
added a commit
to TheKidCoder/JavaScript-autoComplete
that referenced
this pull request
Nov 15, 2016
|
Did anybody find out how minification is accomplished? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw some problems with closures and duplicate declarations. Also refactored to use some more verbose variable names, to help developing - they get minified anyway.
Btw. what do you use for minification? I did not add an updated version of the auto-complete.min.js since I couldn't find, what tool you used.