Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

History surfaces don't get Disposed #2143

Copy link
Copy link
@jpobst

Description

@jpobst
Issue body actions

I'm not sure if this change is correct:
8eefbe5#diff-36d2425cac4ec535e53cf124ae8a76ec1002823dece3982a68ed299224f6484a

(The link doesn't seem to go to the correct spot, but the issue is removing Dispose from BaseHistoryItem and SimpleHistoryItem.)

By removing the Dispose, old_surface doesn't get released (until the eventual finalizer runs).

This can cause unused native memory to linger longer than necessary.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

apiChanges to Pinta's core librariesChanges to Pinta's core libraries

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.