This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Prevent TypeError when using Pikaday in Firefox add-ons #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sto() calls throw TypeErrors in Firefox add-ons if the Window object is not explicitly bound to the setTimeout() method. (TypeError: 'setTimeout' called on an object that does not implement interface Window.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this issue after porting a Chrome extension to Firefox. The datepicker fails to open as the sto() call in Pikaday.draw() throws an exception and stops execution.
I'm not sure exactly what the difference in behaviour is caused by (possibly some kind of security feature?) but binding the window object to setTimeout prevents the errors and doesn't seem to affect functionality in any browsers I tested. Testing for Function.prototype.bind makes sure that the fix doesn't break compatibility for older browsers.