done some code cleanup -> PEP8, fixed some logical stuff like not use…#22
Merged
konstantinpae merged 2 commits intodevelopmentPRTG/PythonMiniProbe:developmentfrom Jun 3, 2015
Merged
done some code cleanup -> PEP8, fixed some logical stuff like not use…#22konstantinpae merged 2 commits intodevelopmentPRTG/PythonMiniProbe:developmentfrom
konstantinpae merged 2 commits intodevelopmentPRTG/PythonMiniProbe:developmentfrom
Conversation
…d variables in all sensors
Contributor
|
Looks good to me... |
Contributor
Author
|
Thanks, so I will merge now |
konstantinpae
added a commit
that referenced
this pull request
Jun 3, 2015
done some code cleanup -> PEP8, fixed some logical stuff like not use…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done some code cleanup -> PEP8, fixed some logical stuff like not used variables in all sensors
@eagle00789 : Could you review this pull request as it involves some minor changes to your sensor code as well. Feedback appreciated.