Updated contribution documentation + Removed WPEngine logo #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wimg
commented
Sep 5, 2019
- Updated contribution documentation to reflect change from master to develop
- Removed WPEngine logo (wasn't working anymore). Kept link.
jrfnl
reviewed
Sep 5, 2019
Member
There was a problem hiding this comment.
- I'm wondering if we may need to update the links for some of the badges in the Readme too to point explicitly to
developormaster? - Regarding projects using PHPCompatibility: I'm wondering if we should limit this to projects which function like a shell around PHPCompatibility, like the first three listed.
Listing external PHPCS standards which just use PHPCompatibility as part of their internal process /require-devseems like it may become a long, arbitrary and unmanageable list.
More external projects / shells:
- PHPCompatibility Checker WordPress plugin
- WordPress Tide project
- The fact that PHPStorm contains build-in support for PHPCompatibility
Member
Author
Changed that. Consistency is indeed key there.
Updated it. |
jrfnl
approved these changes
Sep 5, 2019
Member
|
Thanks! Looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.