PHP 5.6: new NewIconvMbstringCharsetDefault sniff #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0d26ae to
8ec742f
Compare
> all functions that take encoding option use php.internal_encoding as default (e.g. htmlentities/mb_strlen/mb_regex/etc) **Note**: The new sniff will only throw an error when the `testVersion` indicates that both PHP < 5.6 as well as PHP 5.6+ need to be supported. Refs: * https://wiki.php.net/rfc/default_encoding * https://www.php.net/manual/en/migration56.new-features.php#migration56.new-features.default-encoding * https://www.php.net/manual/en/migration56.deprecated.php#migration56.deprecated.iconv-mbstring-encoding Includes unit tests. Fixes 839
8ec742f to
ee2b1ea
Compare
wimg
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The new sniff will only throw an error when the
testVersionindicates that both PHP < 5.6 as well as PHP 5.6+ need to be supported.Refs:
Includes unit tests.
Fixes #839
Notes
This PR does not address the
mb_erg..()functions. For those to work correctly cross-version the encoding needs to be set using themb_regex_encoding()function.As PHPCS cannot determine whether this has already been done in another file/scope, sniffing for this would yield too many false positives.