Update Symfony ruleset #2413
Update Symfony ruleset #2413
Conversation
The was proposed to the SF community and accepted here: so I'm not sure what we could've done more.
This is done by the Please regen. the readme ( |
|
I've just changed the configuration of Symfony to exclude it (symfony/symfony@d559e26). I still think it was a mistake to accept such a change in Symfony. |
|
Then please apply both changes here and regenerate readme, as @SpacePossum asked. |
|
Done |
|
👍 |
|
Thank you @fabpot. |
This PR was merged into the 2.0-dev branch. Discussion ---------- Update Symfony ruleset We've just upgraded PHP-CS-Fixer to 2.0 and we now have a lot of recommendations that we don't want to get on Symfony. The `heredoc` one being one of them. Another rule we don't want, but I didn't find where this is enabled, is the conversion of one-line anonymous functions to multiline ones. Anyone knowns which rule we should disable to avoid that (http://fabbot.io/report/symfony/symfony/20907/a2c7e0634dc7052562b0d42bff5b141b638b7d18 has an example)? Thanks. Commits ------- 750335d removed from the Symfony ruleset rules that we don't want on Symfony
We've just upgraded PHP-CS-Fixer to 2.0 and we now have a lot of recommendations that we don't want to get on Symfony. The
heredocone being one of them.Another rule we don't want, but I didn't find where this is enabled, is the conversion of one-line anonymous functions to multiline ones. Anyone knowns which rule we should disable to avoid that (http://fabbot.io/report/symfony/symfony/20907/a2c7e0634dc7052562b0d42bff5b141b638b7d18 has an example)? Thanks.