Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Todays Sun, PR for branch: feature/WSA #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 244 commits into from
Jun 12, 2025
Merged

Todays Sun, PR for branch: feature/WSA #3652

merged 244 commits into from
Jun 12, 2025

Conversation

ElonOlsson
Copy link
Contributor

This includes a lot, but the over all intention of this is to visualize the very latest simulation output from continuously running models to show the Sun as it is right now. Right now only one model WSA, in the future maybe ENLIL and maybe more.
start
This is a long time coming PR where I've implemented a Dynamic File Sequence Downloader, that for now, when given URL to CCMC server for a dataset where simulation outputs continuously get placed, this will keep track on the time in OpenSpace and only download relevant files accordingly.
This have been integrated with RenderableFieldlinesSequence which has been rewritten and RenderableTimeVaryingSphere which have gotten a lot of edits.

We are looking to get this as a new profile for the release, so with the PR also comes a profile file ready to be tested. You should be able to run the branch with the profile and see it right away.

I'm looking for eyes especially on :
naming of the profile,
naming for the folder for the assets for the profile,
the issue explained in the ui-rewrite slack channel,
the general explanation in the information panel (mission panel),

but also bugs and over all coding practices and probably more I'm forgetting right now.

shyamthyagarajan and others added 30 commits July 26, 2022 14:32
@ElonOlsson
Copy link
Contributor Author

Thanks all for all comments!
Let me address some of the more overarching questions and comments you've written down.
I know a lot of duplications of code is there. There is between RenderableTimeVaryingFitsSphere and RenderableFieldlinesSequence as well as between RenderableTimeVaryingFitsSphere and RenderableTimeVaryingSphere (Where inheritance and implementing support for the dynamic sequence downloader is clashing).
I will make improvements around for the next patch release.

Ylva asked about the GUI issue I've raised concerns about . I find that to not be an issue anymore, I think mainly since I redid the onChange function declarations and addProperty calls in the right order, making sure onChange was declared before adding property.

The scale on the fieldliens: I need to scale them up with the size of the Sun. Is there a different place I should do that instead, or do I need to implement a property?

Naming: We landed on Today's Sun. As the rest of the profile have good one word names, it was difficult to come up with one that would describe the general whole purpose with it. I don't think it's a good idea to add more words to the naming of the profile.
The word magnetosphere is a term not really used for stars and the Sun, but for planets and moons. One can use the magnetic field in the solar corona as the alternative term, which is wordy to be used in a name.

Speaking of wordy. Mission panel info: Ylva has good points about simplifying the language. At the same time, I've written it in a way where I'm saying what content is there and how to use it. Ylva makes a great point about instead focusing on what the content is telling us " What are the fieldlines? What do they show? What do the colors mean? What do the colors on the sun mean? Why should we care about these things? How do they affect us? Etc. " To add this but at the same time keep it short is tricky and I'd appreciate help with it.
And a comment about the audience for this. Ylva also points out "The target audience seemed to be someone who is already familiar with the models." And I would say that that is correct. This is different from a lot of other content in OpenSpace in that way. I've made this in expectation that experts will be using it. However, I agree. It should be more accessible and a lot can be moved to the documentation page instead.

Also on the topic of the mission panel. Using the mile stones. I've thought about this too and I've wanted to add periods where there were CMEs but I recently learned that WSA is not modeling the CMEs but only the ambient background. I also have been wanting to put the end time to be todays date every day, but I believe in LUA we've blocked the use of the system functions for security reasons, which unfortunately is where getting the time lives. If anyone have a work around on that I'd love to add it.

talk about wordy...

@ylvaselling
Copy link
Contributor

I think the scale of the fieldlines is fine, it's just the max value that seems very low compared the scale they actually have. So maybe change the max value of the property, if possible?

If you want help to come up with some text for the mission panel, I'm happy to chip in! Chat gpt could also be a good tool for rephrasing things.

Here are the videos that became 404:
https://github.com/user-attachments/assets/598a92b3-c27d-4dfb-9129-5627a78e6a06

2025-06-10.13-39-13.mp4

Copy link
Contributor

@WeirdRubberDuck WeirdRubberDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adressing the comments and for the detailed response on the comments @ElonOlsson ! This is starting to look good enough to merge to me, especially with the time limit.

In addition to addressing the duplicated code, some documentation should be added for the different renderables. However, this could also be done in a separate PR after this one is merged :)

I agree with Ylva about the wordiness of the mission description - and this is probably the most critical thing to fix before the release.

Doing as you suggested, and move the details on how to use the profile to the documentation page, would solve that problem. Then, the description in the mission could you be a shorter explanation that broadly answers the questions that Ylva so nicely formulated.

You asked for help in doing this, and I'm happy to help too. And as Ylva said, ChatGPT could probably help. But then you still need to provide the answers to the questions - since you're the expert 😉 Listing them again here for convenience

What are the fieldlines? What do they show? What do the colors mean? What do the colors on the sun mean? Why are there two different sizes of the sun? How are these things measured? Why should we care about these things? How do they affect us?

src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
@alexanderbock
Copy link
Member

@ElonOlsson : To get the current time you can use openspace.time.currentWallTime()
@ylvaselling The Scale i believe is for the StaticScale, so we currently don't have the option to change the max value until #1529 is fixed

src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
src/util/dynamicfilesequencedownloader.cpp Outdated Show resolved Hide resolved
@ElonOlsson ElonOlsson merged commit 87c1372 into master Jun 12, 2025
@ElonOlsson ElonOlsson deleted the feature/WSA branch June 12, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.