Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Nov 14, 2024

This PR renames the OpenAPIClient to ProjectNameAPIConfiguration, to avoid name clashes when using multiple openapi integrations.

Fixes #20056

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

Copy link
Contributor

@x-sheep x-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's every instance of the generated doc

4brunu and others added 7 commits November 14, 2024 11:08
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
Co-authored-by: Lennard Sprong <x-sheep@users.noreply.github.com>
@4brunu
Copy link
Contributor Author

4brunu commented Nov 14, 2024

@x-sheep thanks, I merged all your suggestions 👍

@4brunu 4brunu merged commit 2935247 into OpenAPITools:master Nov 15, 2024
17 checks passed
@4brunu 4brunu deleted the feature/swift-rename-api-client branch November 15, 2024 09:35
@wing328 wing328 added this to the 7.10.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][swift6] Generator does not honor ProjectName for APIs client

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.