Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Oct 6, 2024

By default, gcc has a predefined macro “linux”

$ gcc -dM -E - < /dev/null | grep linux
#define __linux 1
#define __gnu_linux__ 1
#define linux 1                    <---------------------- here !
#define __linux__ 1

So if the source code contains "linux", the compilation will fail.
e.g.

/home/runner/work/c/c/kubernetes/model/v1_container_user.h:23:39: error: expected identifier or ‘(’ before numeric constant
   23 |     struct v1_linux_container_user_t *linux; //model
      |                                       ^~~~~

This PR adds "linux" to the reserved keywords to escape "linux" to "_linux" to avoid compilation failure.

@wing328 @zhemant @michelealbano

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ityuhui ityuhui force-pushed the yh-gcc-reserved-1006 branch from f893b34 to a7fc2de Compare October 6, 2024 13:01
Copy link
Contributor

@zhemant zhemant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@wing328 wing328 merged commit ba16934 into OpenAPITools:master Oct 8, 2024
@wing328 wing328 added this to the 7.10.0 milestone Oct 8, 2024
@ityuhui ityuhui deleted the yh-gcc-reserved-1006 branch October 9, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.