supporting 200% and 400% zoom scenarios #482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksboora
suggested changes
Jan 14, 2022
Contributor
ksboora
left a comment
There was a problem hiding this comment.
Pl don't merge these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier during 200% zoom, the panels were overlapping making the text hidden. Some options of the panel were getting out of the viewport and making then inaccessible.
Wrote the custom css for the components to support these scenarios and added a scrollbar to not let the content go out of the view port.
Testing: With these changes I can support 200% zoom across all resolutions and 400% zoom across some resolutions.