Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Add environment tags and extend tag sets to include scopes and type #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
Loading
from
Open

feat: Add environment tags and extend tag sets to include scopes and type #99

wants to merge 10 commits into from

Conversation

grace-rehn
Copy link
Contributor

@grace-rehn grace-rehn commented Sep 29, 2025 •
edited
Loading

  • Updates the Tag Set resource to include new Scopes and Type fields
  • Updates the Tag Set datasource to be able to filter by scope
  • Updates the Environment resource to include new Environment Tag field

Tested against https://github.com/OctopusDeploy/OctopusDeploy/pull/36997

[sc-122529]

Add Scopes and Type to Tag Sets

Resource

Terraform:
image

Octopus:
image

Datasource

Terraform:
image

Terraform State:
image

Add Environment Tags to Environments

Terraform:
image

Octopus:

image

grace-rehn
grace-rehn commented Sep 30, 2025
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@grace-rehn grace-rehn requested a review from a team September 30, 2025 03:48
hnrkndrssn
hnrkndrssn reviewed Sep 30, 2025
View reviewed changes
octopusdeploy_framework/resource_environment_test.go Outdated Show resolved Hide resolved
hnrkndrssn
hnrkndrssn reviewed Sep 30, 2025
View reviewed changes
octopusdeploy_framework/datasource_tag_sets_test.go Outdated Show resolved Hide resolved
hnrkndrssn
hnrkndrssn approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Hold off on merging this for now though please, at least until we've shipped extended tag sets.

HuyPhanNguyen
HuyPhanNguyen approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@HuyPhanNguyen HuyPhanNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wlthomson
wlthomson requested changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@wlthomson wlthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting changes to be safe to prevent an accidental merge. When its ready to go, happy to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wlthomson wlthomson wlthomson requested changes

@hnrkndrssn hnrkndrssn hnrkndrssn approved these changes

@HuyPhanNguyen HuyPhanNguyen HuyPhanNguyen approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grace-rehn @hnrkndrssn @wlthomson @HuyPhanNguyen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.