-
Notifications
You must be signed in to change notification settings - Fork 5
Add lifecycle retention block with strategy #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
234a19d
to
88833b4
Compare
# Conflicts: # octopusdeploy_framework/datasource_lifecycle.go # octopusdeploy_framework/datasource_lifecycle_test.go # octopusdeploy_framework/resource_lifecycle.go # octopusdeploy_framework/resource_lifecycle_retention_test.go # octopusdeploy_framework/resource_lifecycle_test.go # octopusdeploy_framework/schemas/lifecycle.go
susanpann
reviewed
Oct 16, 2025
susanpann
reviewed
Oct 16, 2025
susanpann
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Just 2 comments to consider, may need to review the names for the tests in resource_lifecycle_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
retention_policy
block will be removed and replaced withretention_with_strategy
, a retention block which uses the new "strategy" attribute. Due to deprecation requirements, both blocks must be available for use for 12 months before the old retention block can be officially deleted. This PR enables either block to be used to set retention for a single lifecycle. This is step 2 of the diagram below.sc-123512
PR 2
Results
Resource Use
Only one type of retention block can be used in a single lifecycle.
release_retention_policy
andtentacle_retention_policy
release_retention_with_strategy
andtentacle_retention_with_strategy
When one retention block is used the other will appear in the state as an empty block shown in the image below:
retention_policy
block use will display deprecation warningsDatasource Use
The datasource displays both types of data with a warning to disregard the


retention_policy
as it may display inaccurate data due to not being able to display a "Default" retention setting.